From 2a2e4787250dc38f69d796d8eee8424945867ccf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hern=C3=A2ni=20Marques?= <hernani+magikoopa@vecirex.net>
Date: Fri, 17 Jul 2026 21:53:04 +0200
Subject: [PATCH] android-test: SMOKE_STRICT hard-fail on ANR / missing
 withdraw core

Matrix gates set SMOKE_STRICT=1 so stable-self and published cannot pass
on install-only when System UI ANRs or wallet-core never sees the URI.
---
 .../android-test/run-android-pay-smoke.sh         | 15 ++++++++++++++-
 .../android-test/run-android-variant-matrix.sh    |  2 ++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/scripts/taler-monitoring/android-test/run-android-pay-smoke.sh b/scripts/taler-monitoring/android-test/run-android-pay-smoke.sh
index ef2ca8e..a5a85b5 100755
--- a/scripts/taler-monitoring/android-test/run-android-pay-smoke.sh
+++ b/scripts/taler-monitoring/android-test/run-android-pay-smoke.sh
@@ -184,14 +184,26 @@ fi
 grep -iE 'taler-wallet|prepareBank|preparePay|confirm|error|Error|success' "$OUT_DIR/logcat.txt" \
   | tail -80 >"$OUT_DIR/logcat-taler.txt" || true
 
+# SMOKE_STRICT=1 (matrix gate default): ANR or missing wallet-core withdraw = hard fail
+: "${SMOKE_STRICT:=0}"
+rc=0
 echo
 echo "=== summary ==="
 echo "package installed: $PKG"
 echo "withdraw intent delivered: $WURI"
+if grep -qiE "isn't responding|isn.t responding|System UI isn" "$OUT_DIR/01-ui.xml" 2>/dev/null \
+  || grep -qiE "isn't responding|not responding" "$OUT_DIR/logcat.txt" 2>/dev/null; then
+  echo "FAIL: System UI / app ANR (host too small or emulator hung)"
+  rc=10
+fi
 if grep -q 'prepareBankIntegratedWithdrawal' "$OUT_DIR/logcat.txt" 2>/dev/null; then
   echo "wallet-core: prepareBankIntegratedWithdrawal seen (wallet accepted withdraw URI)"
 else
   echo "wallet-core: prepareBankIntegratedWithdrawal NOT seen (UI may still show onboarding/ANR on small RAM)"
+  if [ "$SMOKE_STRICT" = "1" ]; then
+    echo "FAIL: SMOKE_STRICT=1 requires prepareBankIntegratedWithdrawal in logcat"
+    rc=11
+  fi
 fi
 if [ -n "$PAY_URI" ]; then
   if grep -qiE 'preparePay|confirmPay|pay-template|preparePurchase' "$OUT_DIR/logcat.txt" 2>/dev/null; then
@@ -204,4 +216,5 @@ echo "artifacts: $OUT_DIR/"
 ls -la "$OUT_DIR" | sed 's/^/  /'
 echo
 echo "NOTE: Full unattended UI payment needs a responsive device/emulator (≥6–8 GiB host RAM recommended)."
-echo "This smoke proves: published APK install + deep-link into wallet-core on stack=$STACK."
+echo "This smoke proves: APK install + deep-link delivery on stack=$STACK (strict=$SMOKE_STRICT rc=$rc)."
+exit "$rc"
diff --git a/scripts/taler-monitoring/android-test/run-android-variant-matrix.sh b/scripts/taler-monitoring/android-test/run-android-variant-matrix.sh
index a92d739..3bb3e07 100755
--- a/scripts/taler-monitoring/android-test/run-android-variant-matrix.sh
+++ b/scripts/taler-monitoring/android-test/run-android-variant-matrix.sh
@@ -85,6 +85,7 @@ run_published() {
     OUT_DIR="$out" \
     SERIAL="$SERIAL" \
     AUTO_START_EMULATOR=0 \
+    SMOKE_STRICT="${SMOKE_STRICT:-1}" \
     "$smoke"
   local rc=$?
   set -e
@@ -110,6 +111,7 @@ run_selfbuild() {
     ANDROID_SERIAL="$SERIAL" \
     AUTO_START_EMULATOR=0 \
     PKG=net.taler.wallet.fdroid.debug \
+    SMOKE_STRICT="${SMOKE_STRICT:-1}" \
     "$ROOT/run-android-build-and-smoke.sh"
   local rc=$?
   set -e