From c09c83672da37030f60ca46a0a165e8977880cde Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hern=C3=A2ni=20Marques?= <hernani+magikoopa@vecirex.net>
Date: Fri, 17 Jul 2026 19:04:41 +0200
Subject: [PATCH] monitoring: always print coloured SUMMARY (not only BOX mode)

---
 scripts/taler-monitoring/lib.sh | 69 ++++++++++++++++++---------------
 1 file changed, 38 insertions(+), 31 deletions(-)

diff --git a/scripts/taler-monitoring/lib.sh b/scripts/taler-monitoring/lib.sh
index c3cd2b2..d0d9bce 100755
--- a/scripts/taler-monitoring/lib.sh
+++ b/scripts/taler-monitoring/lib.sh
@@ -760,44 +760,51 @@ summary() {
     done
   fi
 
-  # Coloured totals — same severity badges as check lines
+  # Coloured totals — same severity badges as check lines (always; NO_COLOR blanks ANSI)
   if [ "${BOX:-0}" = "1" ]; then
     printf -- '\n%s┌ SUMMARY ┐%s\n' "$BG_SEC" "$N"
-    printf -- '  %s┌ OK    ┐%s %s%4d%s\n' "$BG_OK" "$N" "$G" "$PASS_N" "$N"
-    if [ "$FAIL_N" -gt 0 ]; then
-      printf -- '  %s┌ ERROR ┐%s %s%4d%s\n' "$BG_ERR" "$N" "$R" "$FAIL_N" "$N"
-    fi
-    if [ "$WARN_N" -gt 0 ]; then
-      printf -- '  %s┌ WARN  ┐%s %s%4d%s\n' "$BG_WARN" "$N" "$Y" "$WARN_N" "$N"
-    fi
-    if [ "$INFO_N" -gt 0 ]; then
-      printf -- '  %s┌ INFO  ┐%s %s%4d%s\n' "$BG_INFO" "$N" "$C" "$INFO_N" "$N"
-    fi
-    if [ "$blk_n" -gt 0 ]; then
-      printf -- '  %s┌ BLOCK ┐%s %s%4d%s\n' "$BG_BLK" "$N" "$M" "$blk_n" "$N"
-    fi
-    # one-line rollup (bold counts)
-    printf -- '  %s%s totals:%s %s%d OK%s' "$B" "$D" "$N" "$G" "$PASS_N" "$N"
-    [ "$FAIL_N" -gt 0 ] && printf -- ' · %s%d ERROR%s' "$R" "$FAIL_N" "$N"
-    [ "$WARN_N" -gt 0 ] && printf -- ' · %s%d WARN%s' "$Y" "$WARN_N" "$N"
-    [ "$INFO_N" -gt 0 ] && printf -- ' · %s%d INFO%s' "$C" "$INFO_N" "$N"
-    [ "$blk_n" -gt 0 ] && printf -- ' · %s%d BLOCKER%s' "$M" "$blk_n" "$N"
-    printf '\n'
-    # overall verdict
-    if [ "$FAIL_N" -eq 0 ] && [ "$blk_n" -eq 0 ] && [ "$WARN_N" -eq 0 ]; then
+    _sum_badge() { # $1=bg $2=tag $3=fg $4=n
+      printf -- '  %s┌ %-5s┐%s %s%4d%s\n' "$1" "$2" "$N" "$3" "$4" "$N"
+    }
+    _sum_badge "$BG_OK" "OK" "$G" "$PASS_N"
+    [ "$FAIL_N" -gt 0 ] && _sum_badge "$BG_ERR" "ERROR" "$R" "$FAIL_N"
+    [ "$WARN_N" -gt 0 ] && _sum_badge "$BG_WARN" "WARN" "$Y" "$WARN_N"
+    [ "$INFO_N" -gt 0 ] && _sum_badge "$BG_INFO" "INFO" "$C" "$INFO_N"
+    [ "$blk_n" -gt 0 ] && _sum_badge "$BG_BLK" "BLOCK" "$M" "$blk_n"
+  else
+    printf -- '\n[ SUMMARY ]\n'
+    printf -- '  [ OK    ] %s%4d%s\n' "$G" "$PASS_N" "$N"
+    [ "$FAIL_N" -gt 0 ] && printf -- '  [ ERROR ] %s%4d%s\n' "$R" "$FAIL_N" "$N"
+    [ "$WARN_N" -gt 0 ] && printf -- '  [ WARN  ] %s%4d%s\n' "$Y" "$WARN_N" "$N"
+    [ "$INFO_N" -gt 0 ] && printf -- '  [ INFO  ] %s%4d%s\n' "$C" "$INFO_N" "$N"
+    [ "$blk_n" -gt 0 ] && printf -- '  [ BLOCK ] %s%4d%s\n' "$M" "$blk_n" "$N"
+  fi
+  # one-line rollup (bold label, severity-coloured counts)
+  printf -- '  %stotals:%s %s%d OK%s' "$B" "$N" "$G" "$PASS_N" "$N"
+  [ "$FAIL_N" -gt 0 ] && printf -- ' · %s%d ERROR%s' "$R" "$FAIL_N" "$N"
+  [ "$WARN_N" -gt 0 ] && printf -- ' · %s%d WARN%s' "$Y" "$WARN_N" "$N"
+  [ "$INFO_N" -gt 0 ] && printf -- ' · %s%d INFO%s' "$C" "$INFO_N" "$N"
+  [ "$blk_n" -gt 0 ] && printf -- ' · %s%d BLOCKER%s' "$M" "$blk_n" "$N"
+  printf '\n'
+  # overall verdict
+  if [ "$FAIL_N" -eq 0 ] && [ "$blk_n" -eq 0 ] && [ "$WARN_N" -eq 0 ]; then
+    if [ "${BOX:-0}" = "1" ]; then
       printf -- '  %s┌ OK    ┐%s %sall clear%s\n' "$BG_OK" "$N" "$G" "$N"
-    elif [ "$FAIL_N" -eq 0 ] && [ "$blk_n" -eq 0 ]; then
+    else
+      printf -- '  %s[ OK    ] all clear%s\n' "$G" "$N"
+    fi
+  elif [ "$FAIL_N" -eq 0 ] && [ "$blk_n" -eq 0 ]; then
+    if [ "${BOX:-0}" = "1" ]; then
       printf -- '  %s┌ WARN  ┐%s %swarnings only (no hard fail)%s\n' "$BG_WARN" "$N" "$Y" "$N"
     else
-      printf -- '  %s┌ ERROR ┐%s %sfailed — see list above%s\n' "$BG_ERR" "$N" "$R" "$N"
+      printf -- '  %s[ WARN  ] warnings only (no hard fail)%s\n' "$Y" "$N"
     fi
   else
-    printf -- 'totals: %s%d OK%s' "$G" "$PASS_N" "$N"
-    [ "$FAIL_N" -gt 0 ] && printf -- ', %s%d ERROR%s' "$R" "$FAIL_N" "$N"
-    [ "$WARN_N" -gt 0 ] && printf -- ', %s%d WARN%s' "$Y" "$WARN_N" "$N"
-    [ "$INFO_N" -gt 0 ] && printf -- ', %s%d INFO%s' "$C" "$INFO_N" "$N"
-    [ "$blk_n" -gt 0 ] && printf -- ', %s%d BLOCKER%s' "$M" "$blk_n" "$N"
-    printf '\n'
+    if [ "${BOX:-0}" = "1" ]; then
+      printf -- '  %s┌ ERROR ┐%s %sfailed — see list above%s\n' "$BG_ERR" "$N" "$R" "$N"
+    else
+      printf -- '  %s[ ERROR ] failed — see list above%s\n' "$R" "$N"
+    fi
   fi
   [ "$FAIL_N" -eq 0 ]
 }