hernani/taler-monitoring
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: drop check_goa_ladder.sh compat shim

Browse source 
No host-agent or suite phase loads the path; taler-monitoring.sh
phase alias goa-ladder already runs check_amount_ladder.sh.
Update docs and admin-log pointer comments to the amount ladder only.
This commit is contained in:
Hernâni Marques 2026-07-19 14:26:07 +02:00
parent 76a253613a
commit 32e7f9668b
No known key found for this signature in database
6 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
CLI-AUTOMATION-NOTES.md
View file

@ -9,7 +9,7 @@ Companions:
- Android GUI → [`android-test/GUI-AUTOMATION-NOTES.md`](./android-test/GUI-AUTOMATION-NOTES.md)
- Git / suite tree → [`VERSIONS.md`](./VERSIONS.md)
Scripts: `check_e2e.sh`, `check_amount_ladder.sh` (compat `check_goa_ladder.sh`), `taler-monitoring.sh`.
Scripts: `check_e2e.sh`, `check_amount_ladder.sh`, `taler-monitoring.sh`.
Legend:

2
TESTS.md
View file

@ -25,7 +25,7 @@ Every check line has a **global** run number and a **grouped** id:
| **sanity** | `check_sanity.sh` | `bank` `exchange` `merchant` |
| **server** | `check_server.sh` | (flat `server-NN` or host groups) |
| **e2e** | `check_e2e.sh` | `prereq` `load` `bank` `wallet` `bankwd` `settle` `pay` `shop` `paivana` `dig` `report` |
| **ladder** | `check_amount_ladder.sh` (alias `check_goa_ladder.sh`) | `plan` `load` `withdraw` `pay` `report` — modes classic / max (`max-ladder`) |
| **ladder** | `check_amount_ladder.sh` | `plan` `load` `withdraw` `pay` `report` — modes classic / max (`max-ladder`); phase alias `goa-ladder` |
**Why groups:** flat `www-001`…`www-080` was hard to talk about.
`www.bank-04` / `e2e.bankwd-02` pin the failure to a logical block.

2
VERSIONS.md
View file

@ -17,7 +17,7 @@ Git tags: `vMAJOR.FEATURE.FIX` (e.g. `v1.8.0`). File `VERSION` omits the `v` pre
| Tag | Date (UTC) | Notes |
|-----|------------|--------|
| **v1.22.0** | 2026-07-19 | **Feature:** modular amount ladder — `ladder/lib_pay.sh` (pay) + withdraw in `check_amount_ladder.sh`; `ladder/extract_rpubs.py`. **max-ladder** hunts highest **withdrawable** and highest **payable** (≤ wallet available). GOA pays use public free-amount template **`goa-free`** (`LADDER_FREE_TEMPLATE`). Classic still default 23-rung wd+pay. `check_goa_ladder.sh` remains a thin compat shim only. |
| **v1.22.0** | 2026-07-19 | **Feature:** modular amount ladder — `ladder/lib_pay.sh` (pay) + withdraw in `check_amount_ladder.sh`; `ladder/extract_rpubs.py`. **max-ladder** hunts highest **withdrawable** and highest **payable** (≤ wallet available). GOA pays use public free-amount template **`goa-free`** (`LADDER_FREE_TEMPLATE`). Classic still default 23-rung wd+pay. Phase alias `goa-ladder` → amount ladder (shim removed). |
| **v1.21.0** | 2026-07-19 | **Feature:** generic **amount ladder** (`check_amount_ladder.sh`; compat shim `check_goa_ladder.sh`). Default **classic** 23-rung withdraw (+ pay when enabled); **max-search** (`max-ladder` / `LADDER_MODE=max`) hunts highest mintable amount (probes default 32, `0`=until timeout). **Pay:** never overspend — soft `SKIP_BALANCE` if amount > wallet available. **Alt units:** report/logs show human names (e.g. `8.15 Tera-GOA (GOA:…)`) + raw. **Fixes bundled:** external extract (no stdin SyntaxError); force-select multi-rpub; soft `CEILING_REJECT` on mint 5110/P0001; crash-proof report. CLI-AUTOMATION-NOTES §3/3a/3b/§15–18. |
| **v1.20.1** | 2026-07-19 | **Docs:** CLI-AUTOMATION-NOTES — force-select empty scrape + ladder pins (§3/3a); wallet-db must not be `*.json` (§15); `taler-helper-sqlite3` needs Python ≥3.11 (§16); portable wall-clock (§17); GOA withdraw checklist (§18). No code change. *(Superseded notes folded into **v1.21.0** feature release.)* |
| **v1.20.0** | 2026-07-19 | **Feature:** domains.conf **`locale`** (l10n) — FP **`fr-CH`**, others **`de-CH`** (aliases ch-FR/ch-DE); UI **`lang=de`** supported (sticky + console tags) but **never** a stock profile default; env `TALER_MON_LOCALE` / `TALER_DOMAIN_LOCALE`. |

2
check_amount_ladder.sh
View file

@ -2,7 +2,7 @@
# check_amount_ladder.sh — generic withdraw/pay amount ladder (any Taler currency)
#
# Currency-agnostic bank landing ladder for GOA, TESTPAYSAN, KUDOS, …
# (formerly check_goa_ladder.sh — shim retained for compatibility).
# (formerly check_goa_ladder.sh; use phase ladder / max-ladder / goa-ladder).
#
# Flow (bank landings):
# 1) GET /intro/auto-account.json → personal *account-* (balance 0)

5
check_goa_ladder.sh
View file

@ -1,5 +0,0 @@
#!/usr/bin/env bash
# Compat shim only — prefer: ./taler-monitoring.sh ladder | max-ladder
# Real implementation: check_amount_ladder.sh (+ ladder/ modules).
ROOT=$(cd "$(dirname "$0")" && pwd)
exec bash "$ROOT/check_amount_ladder.sh" "$@"

2
ladder/README.md
View file

@ -8,7 +8,7 @@ Glued by `../check_amount_ladder.sh` (phase entry: `ladder` / `max-ladder`).
| `lib_pay.sh` | **Payment** ladder: free-amount template orders, classic pay list, max-search highest **payable** ≤ available |
| *(withdraw stays in `check_amount_ladder.sh`)* | **Withdraw** ladder: classic 23-rung plan + max-search highest **withdrawable** |
`check_goa_ladder.sh` at repo root is only a **compat shim** (`exec` → `check_amount_ladder.sh`). Not required for new scripts; phase alias `goa-ladder` already uses the amount ladder.
Phase alias `goa-ladder` maps to `check_amount_ladder.sh` (no separate goa_ladder script).
## Modes